Do not wrap <table> inside <p> on Special:UserRights
authorumherirrender <umherirrender_de.wp@web.de>
Thu, 5 Jun 2014 18:05:34 +0000 (20:05 +0200)
committerumherirrender <umherirrender_de.wp@web.de>
Thu, 5 Jun 2014 18:05:34 +0000 (20:05 +0200)
Special:UserRights has a table inside a paragraph which is invalid html.
The validator will except the open <p> but than gives a error on the
closing </p>: "No p element in scope but a p end tag seen."
IE11 also gives a hint on the console (hint HTML1509).

Fixed this by just removing the paragraph.

Change-Id: Ie17725d0b8018853e445142fa9c436db5471dcc6

includes/specials/SpecialUserrights.php

index 8a5ba1d..411970e 100644 (file)
@@ -547,7 +547,7 @@ class UserrightsPage extends SpecialPage {
                                ->rawParams( $userToolLinks )->parse() .
                        $this->msg( 'userrights-groups-help', $user->getName() )->parse() .
                        $grouplist .
-                       Xml::tags( 'p', null, $this->groupCheckboxes( $groups, $user ) ) .
+                       $this->groupCheckboxes( $groups, $user ) .
                        Xml::openElement( 'table', array( 'id' => 'mw-userrights-table-outer' ) ) .
                                "<tr>
                                        <td class='mw-label'>" .